get edited asset URL from PHP; stop adding timestamp#598
Draft
i-just wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes in this PR:
CkeditorController::actionImageUrl()so that events can do their thing and so thatGeneralConfig::revAssetUrlsis respected.Assets::generateTransform(), which should ensure the correct URL is returnedrevAssetUrlsis set tofalse(the default), as in that case we need something to indicate that the image should be reloaded, even if the URL is the sameThe regex in
_srcInfo()was greedy because the query string can be a part of the asset’s URL. This is the case, e.g. when using Servd’s Assets and Helpers plugin. That’s why I’m leaving it as is.Related issues
#595
#477